Feat: Add Safe Data Preview#36
Open
kw-datamasque wants to merge 3 commits into
Open
Conversation
ClassicMMT
force-pushed
the
typed-safe-data-preview
branch
3 times, most recently
from
July 16, 2026 02:27
69ef38f to
9111d65
Compare
ClassicMMT
changed the title
ClassicMMT
marked this pull request as ready for review
July 16, 2026 02:33
cph-datamasque
left a comment
cph-datamasque
left a comment
Collaborator
There was a problem hiding this comment.
Have a think about whether the UnknownPreview is a safe idea from the point of view of a person using this library.
Remove tests that are just testing pydantic, and collapse repetitive tests using pytest.mark.parametrize().
kw-datamasque
commented
Jul 16, 2026
ClassicMMT
force-pushed
the
typed-safe-data-preview
branch
2 times, most recently
from
July 19, 2026 22:44
62e576e to
5bcf818
Compare
ClassicMMT
changed the title
kw-datamasque
commented
Jul 20, 2026
ClassicMMT
force-pushed
the
typed-safe-data-preview
branch
2 times, most recently
from
July 20, 2026 03:16
799f58f to
10f2e69
Compare
ClassicMMT
force-pushed
the
typed-safe-data-preview
branch
from
July 20, 2026 20:07
10f2e69 to
f01e0b2
Compare
kanewilliams
approved these changes
Jul 20, 2026
kanewilliams
left a comment
kanewilliams
left a comment
Member
There was a problem hiding this comment.
Looks good on my end, conditional on @cph-datamasque's review
cph-datamasque
approved these changes
Jul 21, 2026
|
|
||
|
|
||
| class TemporalBin(BaseModel): | ||
| """One interval of a temporal histogram, with ISO-formatted bounds and a human-readable label.""" |
Collaborator
There was a problem hiding this comment.
should these bounds be datetime then? (may require DM changes)
Collaborator
|
approved, I'll trust that the data structures are correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SafeDataPreviewOptionsonInDataDiscoveryConfigand a typedsafe_data_previewfield on schema-discovery result columns. Changelog entry under 1.1.8 (unreleased).